Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct documented return type of Single#flatMapObservable Function argument #5304

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Correct documented return type of Single#flatMapObservable Function argument #5304

merged 1 commit into from
Apr 20, 2017

Conversation

veyndan
Copy link
Contributor

@veyndan veyndan commented Apr 20, 2017

The argument of Single#flatMapObservable clearly states that it is expecting a Function which returns an ObservableSource but the documentation contradicts that.

@akarnokd akarnokd added this to the 2.0 backlog milestone Apr 20, 2017
@akarnokd
Copy link
Member

Thanks!

@akarnokd akarnokd merged commit bab3071 into ReactiveX:2.x Apr 20, 2017
@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

Merging #5304 into 2.x will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5304      +/-   ##
============================================
- Coverage     96.12%   96.06%   -0.07%     
+ Complexity     5755     5751       -4     
============================================
  Files           629      629              
  Lines         41112    41112              
  Branches       5705     5705              
============================================
- Hits          39520    39493      -27     
- Misses          628      648      +20     
- Partials        964      971       +7
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Single.java 99.33% <ø> (ø) 132 <0> (ø) ⬇️
.../operators/completable/CompletableConcatArray.java 93.75% <0%> (-6.25%) 2% <0%> (ø)
...in/java/io/reactivex/subjects/BehaviorSubject.java 85.93% <0%> (-5.73%) 57% <0%> (+1%)
.../java/io/reactivex/subjects/SerializedSubject.java 88.42% <0%> (-5.27%) 24% <0%> (-2%)
...java/io/reactivex/subjects/CompletableSubject.java 94.8% <0%> (-5.2%) 35% <0%> (-2%)
...ors/observable/ObservableSampleWithObservable.java 92.77% <0%> (-4.82%) 3% <0%> (ø)
...rnal/subscriptions/DeferredScalarSubscription.java 93.84% <0%> (-4.62%) 27% <0%> (-1%)
...vex/internal/operators/flowable/FlowableTimer.java 92.85% <0%> (-3.58%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 96.19% <0%> (-2.72%) 2% <0%> (ø)
...x/internal/operators/flowable/FlowablePublish.java 93.39% <0%> (-2.21%) 9% <0%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c58557...c391967. Read the comment docs.

@akarnokd akarnokd mentioned this pull request Apr 20, 2017
Closed
@veyndan veyndan deleted the doc-single-flatMapObservable branch April 20, 2017 22:02
@michaelEllisUy michaelEllisUy mentioned this pull request Jun 1, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akarnokd akarnokd akarnokd approved these changes

Assignees
No one assigned
Labels
2.x Documentation
Projects
None yet
Milestone
2.x backlog
Development

Successfully merging this pull request may close these issues.
2 participants
@veyndan @akarnokd